Move BOM management and HTML functions to separate modules#192
Conversation
|
Moving the BOM modules to a separate file might be trickier than expected... |
|
I know this is WIP, but in case these hints might help you:
|
|
Thanks, yes, I'm moving things around as I progress.
I think the BOM generation code has grown quite complex, so I need some time to understand it, and make sure we are not passing around more objects than needed, that functions end up in the correct modules, etc. |
I agree they're generic enough to move to |
|
Therefore, unless no glaring errors show up, I would like to merge this soon. Refactoring and optimization of the affected functions can happen in a later PR. Thanks! |
cf2db16 to
bf2792d
Compare
bf2792d to
a96ca7a
Compare
kvid
left a comment
There was a problem hiding this comment.
I can verify that the output is unchanged when generating examples. I do have some simplifications of wv_bom.py in my local repo that I plan to push to a new PR when this is merged, as you requested.
a96ca7a to
e343fdb
Compare
e343fdb to
0e3a24d
Compare
Closes #151.