Skip to content

fix: predicate for updating conversations with backend - WPB-22241 #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
netbe merged 9 commits into from
Dec 10, 2025
Merged

fix: predicate for updating conversations with backend - WPB-22241 #3988

netbe merged 9 commits into from
Dec 10, 2025
+33 −5

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Dec 8, 2025 •
edited by github-actions bot
Loading

BugWPB-22241 [iOS] Don't schedule update conversation calls for deleted conversations

Issue

Right now, it can happen that the ConversationUpdatesGenerator generates workItem on deleted conversations. This PR fixes this in filtering out deleted conversations.

Testing

See test case

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe requested review from a team, David-Henner, johnxnguyen and samwyndham and removed request for a team and johnxnguyen December 8, 2025 09:40
samwyndham
samwyndham approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@netbe netbe enabled auto-merge (squash) December 8, 2025 10:24
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025 •
edited
Loading

Test Results

    8 files  1 011 suites   24m 7s ⏱️
7 447 tests 7 418 ✅ 28 💤 1 ❌
7 448 runs  7 420 ✅ 28 💤 0 ❌

For more details on these failures, see this check.

Results for commit 63698c1.

♻️ This comment has been updated with latest results.

@netbe netbe merged commit 71a8fdc into release/cycle-4.12 Dec 10, 2025
17 checks passed
@netbe netbe deleted the fix/predicate branch December 10, 2025 16:15
zenkins pushed a commit that referenced this pull request Dec 10, 2025
@netbe @github-actions
fix: predicate for updating conversations with backend - WPB-22241 (#…
bc51260 
…3988)
@github-actions github-actions bot mentioned this pull request Dec 10, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwyndham samwyndham samwyndham approved these changes

@David-Henner David-Henner David-Henner approved these changes

Assignees

@netbe netbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@netbe @samwyndham @David-Henner