Skip to content

Conversation

@caldrian
Copy link
Contributor

@caldrian caldrian commented Dec 5, 2025

StoryWPB-21441 [iOS] [Integration] Toggle Apps in Conversation Flow

Issue

When searching for people or bots with an account without a team, the tasksRemaining counter is not decreased to 0, leading to a continuation of withCheckedThrowingContinuation is never called in SearchUsersUseCase.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian enabled auto-merge (squash) December 5, 2025 13:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Test Results

    1 files    150 suites   1m 48s ⏱️
1 299 tests 1 298 ✅ 0 💤 1 ❌
1 299 runs  1 299 ✅ 0 💤 0 ❌

For more details on these failures, see this check.

Results for commit a914b15.

♻️ This comment has been updated with latest results.

@caldrian caldrian marked this pull request as draft December 10, 2025 07:53
auto-merge was automatically disabled December 10, 2025 07:53

Pull request was converted to draft

@caldrian caldrian changed the base branch from release/cycle-4.12 to develop December 10, 2025 07:53
@caldrian caldrian marked this pull request as ready for review December 10, 2025 07:55
@caldrian caldrian added this pull request to the merge queue Dec 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@caldrian caldrian added this pull request to the merge queue Dec 11, 2025
Merged via the queue into develop with commit e7a3d53 Dec 11, 2025
14 checks passed
@caldrian caldrian deleted the fix/leaking-continuation-WPB-21441 branch December 11, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants