Skip to content

chore: remove non mutlibackend code in NSE - WPB-19818 #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
netbe merged 1 commit into from
Dec 10, 2025
Merged

chore: remove non mutlibackend code in NSE - WPB-19818 #3974

netbe merged 1 commit into from
Dec 10, 2025

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Dec 4, 2025 •
edited by github-actions bot
Loading

TaskWPB-19818 [iOS] Delete legacy NSE when multibackend is released

Issue

This is part of removing dead code following multibackend support.

  • Remove code on NSE

Testing

N/A
Runs tests

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe requested a review from johnxnguyen December 4, 2025 09:32
@netbe netbe requested review from a team and David-Henner and removed request for a team December 4, 2025 09:32
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Test Results

  1 files  128 suites   19s ⏱️
452 tests 452 ✅ 0 💤 0 ❌
453 runs  453 ✅ 0 💤 0 ❌

Results for commit 54b4323.

@netbe netbe enabled auto-merge December 9, 2025 12:12
@netbe netbe added this pull request to the merge queue Dec 9, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 9, 2025
@netbe
chore: remove non mutlibackend code in NSE - WPB-19818 (#3974)
b401aac
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2025
@netbe netbe added this pull request to the merge queue Dec 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@netbe netbe added this pull request to the merge queue Dec 10, 2025
Merged via the queue into develop with commit 8a6bd08 Dec 10, 2025
14 checks passed
@netbe netbe deleted the chore/remove-nse branch December 10, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@David-Henner David-Henner David-Henner approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

Assignees

@netbe netbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@netbe @David-Henner @johnxnguyen