-
Notifications
You must be signed in to change notification settings - Fork 24
feat: File versioning - WPB-21660 #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… assets when modified
Test Results2 301 tests 2 273 ✅ 3m 41s ⏱️ Results for commit eeafed9. ♻️ This comment has been updated with latest results. |
...ingTests/WireCells/ImplementationTests/UseCases/WireCellsFetchNodeVersionsUseCaseTests.swift
Show resolved
Hide resolved
...ingTests/WireCells/ImplementationTests/UseCases/WireCellsFetchNodeVersionsUseCaseTests.swift
Show resolved
Hide resolved
WireMessaging/Sources/WireMessagingDomain/WireCells/UseCases/WireCellsGetAssetUseCase.swift
Outdated
Show resolved
Hide resolved
WireMessaging/Sources/WireMessagingDomain/WireCells/UseCases/WireCellsGetAssetUseCase.swift
Outdated
Show resolved
Hide resolved
.../Sources/WireMessagingDomain/WireCells/Protocols/WireCellsLocalAssetRepositoryProtocol.swift
Outdated
Show resolved
Hide resolved
...ging/Sources/WireMessagingDomain/WireCells/UseCases/WireCellsRestoreNodeVersionUseCase.swift
Outdated
Show resolved
Hide resolved
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. A few comments to address but pre-approving as I will soon be on vacation
...rces/WireMessagingUI/WireCells/Components/Files/FileVersioning/FileVersioningViewModel.swift
Outdated
Show resolved
Hide resolved
...rces/WireMessagingUI/WireCells/Components/Files/FileVersioning/FileVersioningViewModel.swift
Outdated
Show resolved
Hide resolved
...rces/WireMessagingUI/WireCells/Components/Files/FileVersioning/FileVersioningViewModel.swift
Outdated
Show resolved
Hide resolved
WireMessaging/Sources/WireMessagingUI/WireCells/Components/Files/FilesViewItemView.swift
Outdated
Show resolved
Hide resolved
|
issue: Could you also put this feature behind the |
netbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple more comments (sorry forgot to press submit before)
...g/Sources/WireMessagingUI/WireCells/Components/Files/FileVersioning/FileVersioningView.swift
Show resolved
Hide resolved
...g/Sources/WireMessagingUI/WireCells/Components/Files/FileVersioning/FileVersioningView.swift
Outdated
Show resolved
Hide resolved
...rces/WireMessagingUI/WireCells/Components/Files/FileVersioning/FileVersioningViewModel.swift
Outdated
Show resolved
Hide resolved
...MessagingTests/WireCells/ImplementationTests/UseCases/WireCellsRestoreNodeUseCaseTests.swift
Show resolved
Hide resolved
netbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:)
Issue
This PR introduces File versioning, specifically the ability for a user to :
note: video taken before merging latest changes from develop also opening and viewing a version has been recently removed from the implementation
https://github.com/user-attachments/assets/6c2defce-cb7b-414b-94b8-00c069cd2d1a
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: