Skip to content

Conversation

@jullianm
Copy link
Contributor

@jullianm jullianm commented Dec 3, 2025

TaskWPB-21660 [iOS] Implement versioning

Issue

This PR introduces File versioning, specifically the ability for a user to :

  • see all versions for a file
  • restore a previous version

note: video taken before merging latest changes from develop also opening and viewing a version has been recently removed from the implementation
https://github.com/user-attachments/assets/6c2defce-cb7b-414b-94b8-00c069cd2d1a

Testing

  • select version history on the files list (item ellipsis)
  • see all versions from that file
  • restore the version it should show up as the most recent version
  • edit and save a file on the Web, it should show up on the list (polling mechanism) as the current version
  • going back to the Files list, when previewing the file, the latest file should show up correctly
  • if on the Files list, and the document is edited on Web, we need to pull to refresh to see the correct file (no polling).

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Test Results

2 301 tests   2 273 ✅  3m 41s ⏱️
  402 suites     28 💤
    4 files        0 ❌

Results for commit eeafed9.

♻️ This comment has been updated with latest results.

@jullianm jullianm requested review from a team, David-Henner and netbe and removed request for a team and WilhelmOks December 11, 2025 14:51
@jullianm jullianm requested a review from samwyndham December 11, 2025 15:01
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A few comments to address but pre-approving as I will soon be on vacation

@samwyndham
Copy link
Contributor

issue: Could you also put this feature behind the wireCellsCollabora feature flag

@jullianm jullianm requested a review from netbe December 15, 2025 09:50
@jullianm jullianm removed the request for review from David-Henner December 15, 2025 14:19
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple more comments (sorry forgot to press submit before)

@jullianm jullianm requested a review from netbe December 16, 2025 14:09
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@jullianm jullianm enabled auto-merge December 18, 2025 13:02
@jullianm jullianm added this pull request to the merge queue Dec 18, 2025
Merged via the queue into develop with commit 8081c4c Dec 18, 2025
13 checks passed
@jullianm jullianm deleted the feat/files-versioning branch December 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants