-
Notifications
You must be signed in to change notification settings - Fork 25
chore: separate user properties isApp and isBot - WPB-21441 #3970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c78cd7e to
7c658d7
Compare
Test Results 4 files 824 suites 8m 13s ⏱️ Results for commit 4b0b73d. ♻️ This comment has been updated with latest results. |
# Conflicts: # wire-ios-data-model/Source/Model/Conversation/ZMConversation+ExternalParticipant.swift
…9-9b3b7db0ecf7da11c2e12c4365f4d3f8a6c270a8' into fix/potential-race-condition-WPB-21441
…rate-isapp-isbot-WPB-21441
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
netbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;) just a typo
Co-authored-by: François Benaiteau <[email protected]>
… chore/separate-isapp-isbot-WPB-21441
…eapp/wire-ios into chore/separate-isapp-isbot-WPB-21441
…eapp/wire-ios into chore/separate-isapp-isbot-WPB-21441
Issue
This PR adds the user properties
isBotandisAppOrBotand changes the implementation ofisApp.Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: