Skip to content

Conversation

@caldrian
Copy link
Contributor

@caldrian caldrian commented Dec 3, 2025

StoryWPB-21441 [iOS] [Integration] Toggle Apps in Conversation Flow

Issue

This PR adds the user properties isBot and isAppOrBot and changes the implementation of isApp.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian force-pushed the chore/separate-isapp-isbot-WPB-21441 branch from c78cd7e to 7c658d7 Compare December 3, 2025 14:27
@caldrian caldrian marked this pull request as ready for review December 3, 2025 14:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Test Results

    4 files    824 suites   8m 13s ⏱️
6 011 tests 5 984 ✅ 27 💤 0 ❌
6 012 runs  5 985 ✅ 27 💤 0 ❌

Results for commit 4b0b73d.

♻️ This comment has been updated with latest results.

# Conflicts:
#	wire-ios-data-model/Source/Model/Conversation/ZMConversation+ExternalParticipant.swift
@caldrian caldrian marked this pull request as draft December 4, 2025 09:21
@caldrian caldrian marked this pull request as ready for review December 4, 2025 10:33
Base automatically changed from fix/potential-race-condition-WPB-21441 to develop December 4, 2025 11:17
@caldrian caldrian requested review from a team, KaterinaWire, netbe and samwyndham and removed request for a team December 5, 2025 10:47
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@caldrian caldrian changed the base branch from develop to release/cycle-4.11 December 5, 2025 12:52
@caldrian caldrian changed the base branch from release/cycle-4.11 to release/cycle-4.12 December 5, 2025 12:53
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;) just a typo

@caldrian caldrian marked this pull request as draft December 10, 2025 09:51
@caldrian caldrian changed the base branch from release/cycle-4.12 to develop December 10, 2025 09:57
@caldrian caldrian marked this pull request as ready for review December 10, 2025 09:58
@caldrian caldrian enabled auto-merge December 10, 2025 10:00
@caldrian caldrian added this pull request to the merge queue Dec 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@caldrian caldrian added this pull request to the merge queue Dec 11, 2025
Merged via the queue into develop with commit b5d21af Dec 11, 2025
17 checks passed
@caldrian caldrian deleted the chore/separate-isapp-isbot-WPB-21441 branch December 11, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants