fix: schedule commit pending proposals - WPB-22062 #3963
Conversation
netbe
force-pushed
the
fix/WPB-22062-commitPendingProposals
branch
from
acec2b8 to
4780bab
Compare
| ).post() | ||
| } | ||
|
|
||
| syncContext.perform { [weak self] in |
There was a problem hiding this comment.
removed as we don't need to repair out of sync conv after initial sync, it will be done by MLSRepairGroup during incrementalSync before iterating over the live stream
| WireLogger.mls.warn("`qualifiedClientID` is missing for selfClient") | ||
| } | ||
|
|
||
| if !isRecovering, mlsFeature.isEnabled { |
There was a problem hiding this comment.
this is now replaced by any item generated by the CommitPendingProposalGenerator
Test Results 1 files 131 suites 16s ⏱️ For more details on these failures, see this check. Results for commit 21bff1e. ♻️ This comment has been updated with latest results. |
netbe
force-pushed
the
fix/WPB-22062-commitPendingProposals
branch
2 times, most recently
from
7d1e8a8 to
806c644
Compare
netbe
force-pushed
the
fix/WPB-22062-commitPendingProposals
branch
from
806c644 to
36c5e90
Compare
| // otherwise assume that things will sort themselves out through conversation reset. | ||
| let feature = await featureRepository.fetchAllowedGlobalOperations() | ||
| if feature.status == .disabled || feature.config.mlsConversationReset == false { | ||
| // check if this can be removed |
There was a problem hiding this comment.
question: why do you suspect it can be removed?
| } | ||
|
|
||
| public func stop() { | ||
| fetchedResultsController.delegate = nil |
There was a problem hiding this comment.
question: should we tear down the FRC instead like in the other generator?
|
|
||
| let timeIntervalSinceNow = timestamp.timeIntervalSinceNow | ||
| if timeIntervalSinceNow > 0 { | ||
| try await Task.sleep(for: .seconds(timeIntervalSinceNow)) |
There was a problem hiding this comment.
question: this will block the sync agent right?
|
|
||
| // Ensure live does NOT start on this state | ||
| live.start_MockMethod = { | ||
| Issue.record("Live generator should not start during incrementalSyncing(.createPushChannel)") |
There was a problem hiding this comment.
question: what is Issue?
There was a problem hiding this comment.
it's a type from SwiftTesting you can basically create your error
Issue
Commit pending proposals should never be executed while performing the incrementalSync. Right now, it's scheduled
via a simple Task.
This PR introduces a generator that will create workItems to commitPendingProposals at the end of incrementalSync and while live sync (push channel open) is running.
CommitPendingProsalsGenerator checks conversations with commitPendingProposalDates and generates CommitPendingProposalItem. This only happens after incrementalSync is done in mainApp.
Then the WorkAgent will run the CommitPendingProposalItem.
Testing
Pending proposals are generated when user leaves a conversation, client is deleted.
Try reproduce these cases and check logs for work-item being generated
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: