fix: Call UI not maximizing after account switch - WPB-20468

wire-ios-sync-engine/Source/SessionManager/PresentationDelegate.swift

@@ -70,4 +70,8 @@ public protocol PresentationDelegate: AnyObject {
 
     // Called when showing the password prompt before joining a group conversation
     func showPasswordPrompt(for conversationName: String, completion: @escaping (String?) -> Void)
+
+    /// Updates the calling UI state if there's an active call
+    func updateActiveCallPresentationStateIfNeeded()
+
 }

wire-ios-sync-engine/Source/SessionManager/SessionManager+Push.swift

@@ -125,6 +125,23 @@ extension SessionManager: UNUserNotificationCenterDelegate {
             fatalError("User session \(session) is not present in backgroundSessions")
         }
     }
+
+    /// Registers an observer to update active call presentation state when the conversation becomes visible.
+    fileprivate func observeConversationDidBecomeVisible() {
+        conversationVisibleObserver = NotificationCenter.default.addObserver(
+            forName: .conversationDidBecomeVisible,
+            object: nil,
+            queue: .main
+        ) { [weak self] _ in
+            guard let self else { return }
+
+            if let observer = conversationVisibleObserver {
+                NotificationCenter.default.removeObserver(observer)
+                conversationVisibleObserver = nil
+            }
+            presentationDelegate?.updateActiveCallPresentationStateIfNeeded()
+        }
+    }
 }
 
 public extension SessionManager {
@@ -138,6 +155,11 @@ public extension SessionManager {
             return
         }
 
+        // If switching accounts, observe when conversation becomes visible to update call UI
+        if session != activeUserSession {
+            observeConversationDidBecomeVisible()
+        }
+
         activateAccount(for: session) {
             self.presentationDelegate?.showConversation(conversation, at: message)
         }
@@ -153,3 +175,7 @@ public extension SessionManager {
         presentationDelegate?.showUserProfile(user: user)
     }
 }
+
+public extension Notification.Name {
+    static let conversationDidBecomeVisible = Notification.Name("ConversationDidBecomeVisible")
+}

wire-ios-sync-engine/Source/SessionManager/SessionManager.swift

@@ -341,6 +341,7 @@
     let jailbreakDetector: JailbreakDetectorProtocol?
     fileprivate var accountTokens: [UUID: [Any]] = [:]
     fileprivate var memoryWarningObserver: NSObjectProtocol?
+    var conversationVisibleObserver: NSObjectProtocol?
     fileprivate var isSelectingAccount: Bool = false
 
     var proxyCredentials: WireTransport.ProxyCredentials?
@@ -473,7 +474,7 @@
             object: nil,
             queue: nil
         ) { [weak self] _ in
             WireLogger.sessionManager.debug("Received memory warning, tearing down background user sessions.")
             self?.tearDownAllBackgroundSessions()
         }
 

wire-ios-sync-engine/Tests/Source/MockPresentationDelegate.swift

@@ -74,4 +74,6 @@ class MockPresentationDelegate: PresentationDelegate {
         completion(mockPassword)
     }
 
+    func updateActiveCallPresentationStateIfNeeded() {}
+
 }

wire-ios/Wire-iOS/Sources/AppRootRouter.swift

@@ -509,8 +509,6 @@ extension AppRootRouter {
             presentAlertForDeletedAccountIfNeeded(error)
             sessionManager.processPendingURLActionDoesNotRequireAuthentication()
         case .authenticated:
-            // This is needed to display an ongoing call when coming from the background.
-            authenticatedRouter?.updateActiveCallPresentationState()
             urlActionRouter.authenticatedRouter = authenticatedRouter
             ZClientViewController.shared?.legalHoldDisclosureController?.discloseCurrentState(cause: .appOpen)
             sessionManager.processPendingURLActionRequiresAuthentication()

wire-ios/Wire-iOS/Sources/URLActionRouter.swift

@@ -143,6 +143,10 @@ class URLActionRouter: URLActionRouterProtocol {
 
 extension URLActionRouter: PresentationDelegate {
 
+    func updateActiveCallPresentationStateIfNeeded() {
+        authenticatedRouter?.updateActiveCallPresentationState()
+    }
+
     func showPasswordPrompt(for conversationName: String, completion: @escaping (String?) -> Void) {
         typealias ConversationAlert = L10n.Localizable.Join.Group.Conversation.Alert
 

wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController+ViewLifeCycle.swift

@@ -41,5 +41,15 @@ extension ConversationViewController {
         isAppearing = false
 
         syncCellsState()
+        notifyConversationDidBecomeVisible()
+
+    }
+
+    private func notifyConversationDidBecomeVisible() {
+        NotificationCenter.default.post(
+            name: .conversationDidBecomeVisible,
+            object: nil
+        )
     }
+
 }