Add support to preserve self-closing syntax on custom HTML elements #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vodik
force-pushed
the
master
branch
4 times, most recently
from
5e5b002 to
cfdec3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a problem where we have to minify HTML that contain custom components, and these components are processed by other systems.
Introduce a new flag,
preserve_self_closing_on_unknown_tags. When set, it preserves self-closing of all unknown tags, allowing them to preserve that attribute as they are processed by this minifier. Otherwise we do the standards compliant minification as normal.I'm not particularly happy about how this reuses
HTML_TAG_WHITESPACE_MINIFICATION. I'm open to suggestions on how to improve that, but it does allow us to move forward with a patch internally..Fixes #257