-
Notifications
You must be signed in to change notification settings - Fork 11
Add possibility for mentions in the forum with '@username' #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frankystone
wants to merge
21
commits into
master
Choose a base branch
from
403_mentions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mirrored on Codeberg as #CB411. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487 #CB403
Adds a new NoticeType
forum_mention, that is a user get emailed if one writes in@usernamein a forum post. This notice type is enabled by default, but can be disabled. The content of the email send to a mentioned user is the same as for other forum notifications, except the subject is "Your name was mentioned…" and the text starts with "Your name was mentioned in a forum post by "user" on topic "topic":". To prevent sending double emails sending 'forum_mention' takes precedence over other notifications. That is:@username, username will receive only the mail with subject "Your name was mentioned…", not "Forum new post".ToDo:
[ ] javascript for a username selection box when writing
@…To get the NoticeType in run
./manage.py migrate