Showing bitrate in video details

[jozefkopcak]

This is what I ended up with, I hope it satisfies :)

[whyboris]

Looks great 🎉
Thank you for your contribution 🙇 🤝 😁

[whyboris]

I'm happy to accept as is. But currently if bitrate property is absent (as it would be for old Hubs), there would be an empty display. I recommend something like the line below, for example:
{{ video.bitrate ? '| ' + video.bitrate + ' mb/s' : '' }}

[jozefkopcak]

There will always be a bitrate property, because it's calculated from videoSize and duration, which are present in every video there is (if I understand correctly).

[whyboris]

Oh you're right! I'm sorry, in my mind, before I saw your code, I was thinking you were grabbing the bitrate from what FFmpeg was returning (when initially scanning the video), and then I commented based on my guess about your code rather than your code 😓

I like your implementation rather than what I was thinking, since it provides previously-scanned videos with a bitrate estimate!

I'll merge this in soon 👏

[whyboris]

Closes issue #712 🙇 🤝 😁 Thank you!

[whyboris]

Thank you @jozefkopcak for the lovely contribution to Video Hub App 🙇

I might tweak it a bit before release (I think the standard way people think about bitrate is using bits, so I just need to multiply by 8 in your formula 😅).

To this day I get frustrated between "megabits" and "megabytes" (and in the Issue asked for the wrong thing I think) - and while I like seeing how many megabytes are used per second, I think most video people expect megabits 🤷 (unsure why - perhaps because this measure was easier to think about when streaming over the internet, which for some annoying reason was in bits not in bytes )