Sorting option for aspect ratio (#399)

[martincaron]

Added sorting option for aspect ratio. ( Issue #399 )

• New setting option under Search Settings -> Sorting options in the dropdown
• For every video compute aspectRatio = ImageElement.width / ImageElement.height
• Implemented Ascending and Descending order
• Division by Zero doesn't seem possible because we have AllowedScreenshotHeight type upstream preventing a height of 0, but I can add some checks to be safe. Feedback ?

[whyboris]

Thank you for the PR 🙇
Code looks good -- I'll test locally and likely merge in before releasing 2.2.3 🎉

Minor notes (no need to change, just food for thought):

• you can use ternary return decreasing ? 1 : -1 as a shorter way of writing what you have
• we can make the sorting faster (I'll check on 10,000 video hub if it's slow) by pre-computing the ratios in the insertTemporaryFields see: https://github.com/whyboris/Video-Hub-App/blob/master/main-support.ts#L93
  • if we do this we should then remember to insertTemporaryFields https://github.com/whyboris/Video-Hub-App/blob/master/main-support.ts#L174
  • with 10,000 videos when trying to sort by a value there are going to be super-many comparisons, and not having to divide numbers would be much faster 🤔

👋 🙂 👍

[martincaron]

All makes sense ! 👍
I should be able to make these changes

[whyboris]

@martincaron -- I tested things out on 10,000 videos in a hub and the sorting is so fast I don't think we need to optimize anything.

If you think it may be worth doing, please feel free to open a new PR. I'm eagerly merging this one as it concludes the version 2.2.3 release :tada

[whyboris]

Works beautifully!
Tested on a 10,000-large video hub and the sort speed is fine, no need to optimize anything 👌