Raise exception when cdparanoia can't read any frames#328
Merged
Conversation
Freso
approved these changes
Nov 9, 2018
Freso
left a comment
Freso
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me. Maybe a small language change.
JoeLametta
force-pushed
the
feature/issue-202-zerodivisionerror
branch
from
b29576e to
c0637b1
Compare
JoeLametta
changed the title
Collaborator
Author
|
Merged, thanks @Freso for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit effectively reverts #159. Whipper now raises an exception again but with a clearer textual description.
Closes #202.