Task/optimize showing markers logic #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phpduy
requested changes
Dec 9, 2024
lib-compose/src/main/java/com/what3words/components/compose/maps/W3WMapDefaults.kt
Outdated
Show resolved
Hide resolved
|
|
||
| val selectedAddress: W3WMarker? = null, | ||
|
|
||
| val listMarkers: ImmutableMap<String, ImmutableList<W3WMarker>> = persistentMapOf(), |
Contributor
There was a problem hiding this comment.
I do think we move this map into the MapManager, and the W3WMapState only contains a list of markers
kaytran2992
force-pushed
the
task/Optimize-showing-markers-logic
branch
from
2b85e19 to
5d04dcf
Compare
kaytran2992
force-pushed
the
task/Optimize-showing-markers-logic
branch
2 times, most recently
from
c01bd7e to
3f949ed
Compare
phpduy
force-pushed
the
task/Optimize-showing-markers-logic
branch
from
3f949ed to
3c9f119
Compare
phpduy
approved these changes
Dec 10, 2024
phpduy
merged commit e1fed4d
into
epic/MT-6865-Create-a-new-UI-for-Map-component
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.