Move vibe inversion into vibe task#90
Merged
Merged
Conversation
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] move vibe inversion into vibe task
Move vibe inversion into vibe task
May 31, 2025
QMasterMoo
reviewed
Jun 1, 2025
QMasterMoo
left a comment
Member
There was a problem hiding this comment.
Good start, but needs a few things
…able inversion probability, remove tests Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
QMasterMoo
reviewed
Jun 1, 2025
Comment on lines
+71
to
+86
| Please figure out the vibe of this prompt and then provide the OPPOSITE vibe: | ||
|
|
||
| {prompt} | ||
|
|
||
| Please return a one sentence summary of the OPPOSITE vibe from what was detected. | ||
| Please be as concise as possible. | ||
| Please do not include any other text or formatting. Just the opposite vibe. | ||
| """) | ||
| else: | ||
| vibe_prompt = dedent(f""" | ||
| Please figure out the vibe of this prompt: | ||
|
|
||
| {prompt} | ||
|
|
||
| Please return a one sentence summary of the vibe. Please be as concise as possible. | ||
| Please do not include any other text or formatting. Just the vibe. |
Member
There was a problem hiding this comment.
Please in all these sentences is not necessary. Remove and replace them with more precise language, please
Contributor
Author
There was a problem hiding this comment.
Removed all unnecessary "Please" words from the vibe prompt instructions and replaced them with more direct imperative statements for precise language. Commit e126708
Co-authored-by: QMasterMoo <3915399+QMasterMoo@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 36.20% 36.17% -0.04%
==========================================
Files 66 66
Lines 2563 2560 -3
Branches 167 167
==========================================
- Hits 928 926 -2
+ Misses 1624 1623 -1
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the vibe inversion logic from the context prompt generation phase into the vibe generation phase, making the vibe "pre-inverted" when needed.
Changes Made
Before
get_vibeactivityGenerateContextPromptParams.__post_init__(), a random decision was made to invert the vibe (10% chance)After
get_vibeactivity now handles inversion internally with the same 10% probabilityGenerateContextPromptParamsno longer needs theshould_invert_vibefield or random logicgenerate_context_promptis simplified without inversion handlingBenefits
Example
Fixes #63.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.