Try out tombi #122
Try out tombi #122
Conversation
| echo 'To fix toml fmt, please run `tombi fmt`.' | ||
| echo 'You can find taplo here: http://tombi-toml.github.io/tombi/.' | ||
| echo 'Also use the `Tombi` extension.' | ||
| echo 'You can find the extension here: https://marketplace.visualstudio.com/items?itemName=tombi-toml.tombi' |
There was a problem hiding this comment.
I should open an upstream issue about the Tombi VSCode extension not always inserting a newline at the end of the file when formatting it.
There was a problem hiding this comment.
It should be respecting .editorconfig
There was a problem hiding this comment.
Okay, there's now an upstream issue about this. Turns out I didn't have to open one, I just had to wait
Cargo.toml
Outdated
| license = "MIT OR Apache-2.0" | ||
| repository = "https://github.com/wgsl-tooling-wg/wesl-rs" | ||
| version = "0.2.0" | ||
| authors = ["Mathis Brossier <mathis.brossier@gmail.com>", "WESL Contributors"] |
There was a problem hiding this comment.
Is it sorting the authors? if possible, I'd like the other way around.
Not crucial, but author order matters.
There was a problem hiding this comment.
There was a problem hiding this comment.
Turns out that the authors field got deprecated and I didn't get a memo
There was a problem hiding this comment.
woah, that's unexpected! I don't understand the move, I mean it's a crucial piece of information. We'd have to provide it in some other way I guess.
There was a problem hiding this comment.
Yeah, I'm still debating where that info goes. Does it go in the LICENSE file? Is the fact that GitHub tracks the contributors good enough? Or does it go somewhere else?
|
This should now be ready, it only took a few tweaks to Tombi :) |
| with: | ||
| config: '.markdownlint.jsonc' | ||
| globs: '**/*.md' | ||
| config: ".markdownlint.jsonc" |
There was a problem hiding this comment.
Just FYI, double quotes in YAML have different semantics than single quotes. It's like writing format!("X") instead of just "X".
|
Thanks @stefnotch 💯 |
This is what it'd look like if we switched to tombi. I'm leaving a few comments in interesting places.