AirflowTranslator Bug Fix (Added Sanitization) #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owTranslator. (Specifically it's use of task_ids as variable names in the generated DAG.)
Member
|
@sukaryo-heilscher, tests seem to be failing on this PR. Could you please take a look? Thank you |
Contributor
|
I'll take a look. The change is for the Airflow translator, and the failed test is for Swift-T.... so it's odd. Perhaps the Swift-T executor isn't really stable.... |
Contributor
|
Ok, it's actually that the Dockerhub API call failed to get the SwiftT Docker image. So it's a transient CI failure. So I am going to merge, which will relaunch the CI and everything should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug of some recipes not working by adding sanitization to AirflowTranslator. (Specifically it's use of task_ids as variable names in the generated DAG.)