Skip to content

Conversation

@jxom
Copy link
Member

@jxom jxom commented Aug 15, 2024

PR-Codex overview

This PR adds optional getNonce functionality to SmartAccountImplementation and updates related test cases and implementations.

Detailed summary

  • Made getNonce optional on SmartAccountImplementation
  • Updated test cases for getNonce return value
  • Updated types.ts to reflect optional getNonce function
  • Updated toSmartAccount.ts and implementations to handle optional getNonce functionality

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem 🔄 Building (Inspect) Visit Preview Aug 15, 2024 9:05pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 1e179dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jxom jxom merged commit a8c78cb into main Aug 15, 2024
@jxom jxom deleted the hoist-aa-nonce-logic branch August 15, 2024 21:09
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 60.31 KB (0%) 1.3 s (0%) 5.4 s (+1.11% 🔺) 6.6 s
const viem = require('viem') (cjs) 70.89 KB (0%) 1.5 s (0%) 9 s (+81.37% 🔺) 10.4 s
import { createClient, http } from 'viem' 6.22 KB (0%) 125 ms (0%) 189 ms (-5.15% 🔽) 314 ms
import * from 'viem/account-abstraction' 43.72 KB (-0.01% 🔽) 875 ms (-0.01% 🔽) 4.1 s (+59.76% 🔺) 4.9 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 33.99 KB (+0.08% 🔺) 680 ms (+0.08% 🔺) 3.4 s (+35.09% 🔺) 4 s
import * from 'viem/accounts' 74.4 KB (0%) 1.5 s (0%) 3.6 s (+18.83% 🔺) 5.1 s
import { privateKeyToAccount } from 'viem/accounts' 19.43 KB (0%) 389 ms (0%) 1.3 s (+10.03% 🔺) 1.7 s
import * from 'viem/actions' 45.88 KB (0%) 918 ms (0%) 4.7 s (+40.9% 🔺) 5.6 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 19 ms (+43.8% 🔺) 29 ms
import * from 'viem/chains' 31.07 KB (0%) 622 ms (0%) 3.1 s (+53.24% 🔺) 3.8 s
import { mainnet } from 'viem/chains' 324 B (0%) 10 ms (0%) 71 ms (+210.22% 🔺) 81 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 20 ms (-30.61% 🔽) 41 ms
import * from 'viem/ens' 45.42 KB (0%) 909 ms (0%) 3.1 s (+36.27% 🔺) 4 s
import { getEnsAvatar } from 'viem/ens' 22.13 KB (0%) 443 ms (0%) 2 s (+27.13% 🔺) 2.5 s
import * from 'viem/siwe' 30.24 KB (0%) 605 ms (0%) 3 s (+21.23% 🔺) 3.6 s
import { verifySiweMessage } from 'viem/siwe' 29.15 KB (0%) 584 ms (0%) 4.4 s (+44.49% 🔺) 5 s

@github-actions github-actions bot mentioned this pull request Aug 14, 2024
@codecov
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (3749838) to head (1e179dc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2620   +/-   ##
=======================================
  Coverage   99.66%   99.67%           
=======================================
  Files         771      771           
  Lines       69455    69457    +2     
  Branches     3271     3273    +2     
=======================================
+ Hits        69224    69228    +4     
+ Misses        217      215    -2     
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants