use repeat_interleave for input_features in kd_trainer#121
Open
zhuxiaoxuhit wants to merge 1 commit intowenet-e2e:mainfrom
Open
use repeat_interleave for input_features in kd_trainer#121zhuxiaoxuhit wants to merge 1 commit intowenet-e2e:mainfrom
zhuxiaoxuhit wants to merge 1 commit intowenet-e2e:mainfrom
Conversation
yuekaizhang
approved these changes
Mar 9, 2026
Contributor
|
@zhuxiaoxuhit Thanks. |
Contributor
|
@robin1001 Would you mind helping merge this one also? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same issue as #119 but in KnowledgeDistillationTrainer._prepare_logprob_inputs.
input_features uses .repeat(num_generations, 1, 1) while all other tensors in the same function use .repeat_interleave(num_generations, dim=0). These two produce different element orderings when batch size > 1:
So when batch size > 1, input_features ends up paired with the wrong completions during log probability computation, making both the student and teacher logprob calculations incorrect and corrupting the KD training signal.