feat: spdx license lint gererated by Kiro (human PR in #15847 btw)#85
Closed
feat: spdx license lint gererated by Kiro (human PR in #15847 btw)#85
Conversation
444711c to
5de6388
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Cargo lint to validate
package.licensefields against SPDX license expression standards. The change is thoroughly planned and documented, including requirements, design, tasks, and dependency updates. The new lint will help package authors ensure their license expressions are correctly formatted, improving compatibility with tools and aligning validation with crates.io. The implementation focuses on robust error reporting, edition-specific defaults, and comprehensive testing.Key changes:
SPDX License Validation Lint Design and Requirements
spdxcrate, diagnostic strategies, testing approach, and implementation phases for the newinvalid_license_expressionlint.Implementation Planning
Dependency and Workspace Updates
spdxcrate (version0.10.9) to the workspace and main dependencies inCargo.tomlto enable SPDX license expression validation. [1] [2]Cargo.tomlfor readability and maintainability, but with no functional changes. [1] [2] [3] [4] [5] [6]These changes lay the groundwork for robust SPDX license validation in Cargo, ensuring consistency, clear error reporting, and future extensibility.