remove reliance on ES5 arguments and use ES6 rest parameters instead#1176
Open
remove reliance on ES5 arguments and use ES6 rest parameters instead#1176
arguments and use ES6 rest parameters instead#1176Conversation
also bring the style of the safari shim closer to the rest of the code and add a test for the correct number of arguments in the polyfilled methods. Fixes #1025
fippo
force-pushed
the
es5-arguments-begone
branch
from
f0d14fd to
31b486a
Compare
henbos
approved these changes
Mar 4, 2026
fippo
added a commit
to rtcstats/rtcstats
that referenced
this pull request
Mar 4, 2026
similar to what is done in webrtcHacks/adapter#1176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also bring the style of the safari shim closer to the rest of the code and add a test for the correct number of arguments in the polyfilled methods.
Fixes #1025