Skip to content

Conversation

@metaclips
Copy link
Member

@metaclips metaclips commented Nov 15, 2020

Improve project folder and test format. @rainliu @Sean-Der

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #11 (335f841) into master (779a0bb) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   63.37%   63.48%   +0.11%     
==========================================
  Files         131      129       -2     
  Lines        5987     5628     -359     
  Branches     1326     1217     -109     
==========================================
- Hits         3794     3573     -221     
+ Misses       1049     1041       -8     
+ Partials     1144     1014     -130     
Impacted Files Coverage Δ
srtp/src/cipher/cipher_aes_cm_hmac_sha1.rs 78.08% <ø> (ø)
srtp/src/context/srtp_test.rs 0.00% <ø> (-71.63%) ⬇️
srtp/src/key_derivation/mod.rs 72.72% <ø> (ø)
srtp/src/lib.rs 100.00% <ø> (ø)
srtp/src/option.rs 100.00% <ø> (ø)
srtp/src/protection_profile/mod.rs 72.22% <ø> (ø)
srtp/src/stream.rs 59.09% <ø> (ø)
srtp/src/context/mod.rs 89.69% <100.00%> (ø)
srtp/src/session/mod.rs 56.11% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779a0bb...335f841. Read the comment docs.

@metaclips metaclips marked this pull request as ready for review November 15, 2020 15:01
@rainliu rainliu merged commit 083c95f into webrtc-rs:master Nov 15, 2020
@metaclips metaclips deleted the SRTP-improve-project-folder-structure-and-test branch November 15, 2020 17:44
algesten pushed a commit that referenced this pull request Aug 23, 2022
Document cancel_rx behavior on Agent::dial and Agent::accept
algesten pushed a commit that referenced this pull request Aug 23, 2022
Fixed CBC encryption and decryption
algesten pushed a commit that referenced this pull request Aug 23, 2022
algesten pushed a commit that referenced this pull request Aug 23, 2022
minor doc comment fix in lib.rs
algesten pushed a commit that referenced this pull request Aug 23, 2022
Fixed spelling of convenience
algesten pushed a commit that referenced this pull request Aug 23, 2022
[PollStream] remove unnecessary lifetime from ReadFut
algesten pushed a commit that referenced this pull request Aug 23, 2022
* return early if the incoming stream was reset

NOTE: we don't need to shutdown the stream as it was already done by the
association minus sending the reset request, which is not needed in this
case (i.e. if we've just received one, we don't need to send one back in
response).

Refs webrtc-rs/sctp#14

* do not account for data, which we've failed to send

* format code

* only count number of bytes actually sent

not the number of bytes we're going to send
https://github.com/webrtc-rs/data/pull/11/files#r904854127
algesten pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants