[pull] master from NLnetLabs:master#76
Merged
pull[bot] merged 4 commits intowebfutureiorepo:masterfrom Mar 6, 2026
Merged
Conversation
The PR that added logging of old and new serials (#112) changed indentation to spaces. Change it back to tabs to match the rest of the code base.
Make it clear which serial is the old ignored one (received from the remote server) and which is the local, newer one. You shouldn't have to read the source code to definitely tell which is which. While you could infer which serial is which by checking which one is larger, it's not always easy to tell at a glance, so it's better to spell it out explicitly in the log message.
Improve ignored old serial log message
- Merge #477: Improve ignored old serial log message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )