-
-
Notifications
You must be signed in to change notification settings - Fork 25
Add Python bindings for jsartoolkitNFT #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kalwalt
wants to merge
70
commits into
dev
Choose a base branch
from
feature-pyton-bindings
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalwalt
commented
Feb 21, 2025
kalwalt
commented
Feb 21, 2025
- solve isse with addNFTMarkers
…uilding Python bindings
… remove unnecessary dependency installation
…sing vcpkg and streamline include/library directories
…compile_args in setup.py
…p.py to include necessary libraries
Member
Author
|
Now the project can be build for both Linux and Windows OS's, it can be improved but it is an important step! |
…ent and improve code safety
…mage data validation
Member
Author
|
The tests doesn't fails anyway it seems that the marker is not detected, maybe i'm not providing the right data? |
…rove code structure
…d add CMake policy version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python bindings for JsartoolkitNFT
In this PR i want to develop python bindings for jsartoolkitNFT. Of course, this means i will not transpile typescript/javascript code to python, instead i created C++ glue code to use with
setuptoolsandpybind11, so creating python binding code.There are some issues and i will list here to take note and solve them.
Most of the methods in ArtoolKitNFT_py.cpp are transpiled to python, the
getNFTMarkerInfois not yet implemented. i have not a clear idea on how is better deal the object that return as in the C++ code for emscripten and convert to python.In this PR i will only propose some small tests, instead of a complete wrapper.
Issues and tasks to solve
\nso all logs are scrambled lines. Solved with commit fcab895 and a0d4d8dgetKpmImageWidthandgetKpmImageHeightcause compilations errors, so i excluded both from the build process.getNFTMarkerInfoneed to be implemented. Solved with commit 7ce0076include/AR/config.hat line 540 (excluded #error option)unittestpytest