This repository was archived by the owner on Mar 5, 2025. It is now read-only.
add geth fault tolerance tests #7104
Merged
+147
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2024 21:13
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 230a364 | Previous: e47e1da | Ratio |
|---|---|---|---|
processingTx |
8973 ops/sec (±4.76%) |
8969 ops/sec (±5.32%) |
1.00 |
processingContractDeploy |
40000 ops/sec (±6.26%) |
38761 ops/sec (±7.89%) |
0.97 |
processingContractMethodSend |
15498 ops/sec (±7.91%) |
15900 ops/sec (±7.01%) |
1.03 |
processingContractMethodCall |
27521 ops/sec (±7.98%) |
28097 ops/sec (±6.28%) |
1.02 |
abiEncode |
44148 ops/sec (±6.96%) |
44753 ops/sec (±7.71%) |
1.01 |
abiDecode |
29934 ops/sec (±8.03%) |
29942 ops/sec (±8.29%) |
1.00 |
sign |
1543 ops/sec (±3.59%) |
1578 ops/sec (±0.97%) |
1.02 |
verify |
373 ops/sec (±0.54%) |
365 ops/sec (±3.03%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
luu-alex
requested review from
Muhammad-Altabba,
avkos and
jdevcs
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7104 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 215 215
Lines 8334 8334
Branches 2296 2296
=======================================
Hits 7897 7897
Misses 437 437
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6776
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.