Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

catching promise - legacy provider error #7022

Merged
luu-alex merged 13 commits into from
May 14, 2024
Merged

catching promise - legacy provider error #7022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
59f6038
adding data check for revert util method
Apr 30, 2024
b08ba9e
fix up tests
Apr 30, 2024
5efced4
fix lint
Apr 30, 2024
87a164f
change legacy request
May 7, 2024
e810ab3
revert contract changes, add try catch
May 8, 2024
f1819bc
fix lint
May 8, 2024
c6b0618
Merge branch '4.x' into add-check-revert
May 8, 2024
024de10
fix changes
May 9, 2024
4a70466
update tests
May 9, 2024
3ee777a
lint and feedback
May 9, 2024
ab3d5df
update test
May 9, 2024
8cc7544
update test
May 9, 2024
fa2461c
format
May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/web3-eth/src/rpc_method_wrappers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,6 @@ export function sendTransaction<
transaction,
transactionFormatted,
});

await sendTxHelper.checkRevertBeforeSending(
transactionFormatted as TransactionCall,
);
Expand Down
3 changes: 2 additions & 1 deletion packages/web3-eth/src/utils/send_tx_helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ export class SendTxHelper<
}

public async checkRevertBeforeSending(tx: TransactionCall) {
if (this.options.checkRevertBeforeSending !== false) {
// should not check revert reason if data is not provided
if (this.options.checkRevertBeforeSending !== false && !isNullish(tx.data)) {
const reason = await getRevertReason(this.web3Context, tx, this.options.contractAbi);
if (reason !== undefined) {
throw await getTransactionError<ReturnFormat>(
Expand Down