-
Notifications
You must be signed in to change notification settings - Fork 5.1k
ensure backward compatibility for Web3 constructor #5221
ensure backward compatibility for Web3 constructor #5221
Conversation
nazarhussain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this change to every default export in all the packages.
|
With the last commit, the However, this also means that the |
The line, where the comment was on, has been deleted
nazarhussain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart form the mentioned change, we need to apply same changes to all packages which are using export default.
0f6ca5a to
071959c
Compare
|
lgtm, plus we should add simplest blackbox tests as well #5261 as part of new PR |
4028893 to
18078f3
Compare
7e83fa3 to
b2c957f
Compare
Signed-off-by: Muhammad-Altabba <[email protected]>
b2c957f to
603d525
Compare
Description
Fixes #(5196)
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.yarn run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.