Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 5, 2022

Description

This PR is for CI checks of #5146

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

* add createAccessList method type in web3.eth

* add optional error field in CreateAccessList result type

* update CHANGELOG.md

Co-authored-by: Junaid <[email protected]>
@jdevcs jdevcs self-assigned this Jul 5, 2022
@render
Copy link

render bot commented Jul 5, 2022

@coveralls
Copy link

coveralls commented Jul 5, 2022

Pull Request Test Coverage Report for Build 2615891358

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.342%

Totals Coverage Status
Change from base Build 2615752940: 0.0%
Covered Lines: 3262
Relevant Lines: 4138

💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented Jul 5, 2022

The code changes in this PR are approved in #5146 , and all CI checks are passing in this PR, so merging.

@jdevcs jdevcs merged commit 57b6dc4 into 1.x Jul 5, 2022
@jdevcs jdevcs deleted the junaid/createaccesslisttypes branch July 5, 2022 11:56
@jdevcs jdevcs mentioned this pull request Jul 5, 2022
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants