Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@itxtoledo
Copy link

This PR adds missing type "receive"

example in solidity:

receive() external payable {
        // any code
 }

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

This PR adds missing type "receive"

example in solidity:

```solidity
receive() external payable {
        // any code
 }
```
@jdevcs jdevcs added the 1.x 1.0 related issues label Jun 28, 2022
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itxtoledo Thanks for your contribution. changelog.md update is also required.

@jdevcs jdevcs requested review from avkos and luu-alex June 28, 2022 11:51
@jdevcs jdevcs added the Future Release For future release. label Jun 28, 2022
@coveralls
Copy link

coveralls commented Jun 30, 2022

Pull Request Test Coverage Report for Build 2867694442

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.255%

Totals Coverage Status
Change from base Build 2775256859: 0.0%
Covered Lines: 3402
Relevant Lines: 4432

💛 - Coveralls

@luu-alex luu-alex requested a review from jdevcs July 10, 2022 17:23
@nikoulai nikoulai self-requested a review July 11, 2022 07:58
@jdevcs jdevcs changed the base branch from 1.x to junaid/5165missingfunctiontypereceivee2e September 6, 2022 12:49
@jdevcs jdevcs merged commit 41e7995 into web3:junaid/5165missingfunctiontypereceivee2e Sep 6, 2022
jdevcs added a commit that referenced this pull request Sep 6, 2022
* Fix: add missing function type "receive"

This PR adds missing type "receive"

example in solidity:

```solidity
receive() external payable {
        // any code
 }
```

* Update Changgelog

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Oleksii Kosynskyi <[email protected]>
Co-authored-by: Junaid <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>

Co-authored-by: Gustavo <[email protected]>
Co-authored-by: Oleksii Kosynskyi <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
@jdevcs
Copy link
Contributor

jdevcs commented Sep 6, 2022

Merged into 1.x via #5165

This was referenced Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Future Release For future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants