-
Notifications
You must be signed in to change notification settings - Fork 5.1k
updating web3 utils BN #5132
Conversation
|
Your Render PR Server URL is https://web3-js-pr-5132.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cajti94gqg46e5e17g3g. |
Pull Request Test Coverage Report for Build 2496163757
💛 - Coveralls |
nazarhussain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing I observed is that the bundle size for this RC release is increased. Do you suspect any particular reason for it?
|
@nazarhussain has the bundlesize increased? running |
|
@luu-alex Please check this https://bundlephobia.com/package/[email protected] |
|
@nazarhussain Ah I see, I believe the bundle size becoming larger is due to upgrading ether packages we were using. To note, our bundle now includes @ethersproject/[email protected] |
Was testing 1.7.4-rc.1 and many open zeppelin testcases were breaking due to the change of updating BN, this was due to us adding
BNwrappedand not adding the prototype and attributes.This PR adds the methods/attributes to the BN object and allows the synthetix tests to pass.