Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 16, 2022

Description

#5030

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs self-assigned this May 16, 2022
@render
Copy link

render bot commented May 16, 2022

"webpack": "^4.44.2",
"webpack-cli": "^4.9.1"
"webpack-cli": "^4.9.1",
"@types/prettier": "2.6.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm i updates @types/prettier in deep path in package lock to lib with breaking changes so fixing its version here.

@jdevcs jdevcs marked this pull request as ready for review May 16, 2022 18:27
@jdevcs jdevcs merged commit 2c0324a into 1.x May 17, 2022
@jdevcs jdevcs deleted the junaid/5030typesprettier branch May 17, 2022 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants