Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 4, 2022

For tests of (#4911) in CI actions.

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

…4911)

* returnTransactionObjects val affects resolve type

* Update CHANGELOG.md
@jdevcs jdevcs added the 1.x 1.0 related issues label May 4, 2022
@jdevcs jdevcs self-assigned this May 4, 2022
@render
Copy link

render bot commented May 4, 2022

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2269750189

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.495%

Totals Coverage Status
Change from base Build 2236725384: 0.0%
Covered Lines: 3242
Relevant Lines: 4107

💛 - Coveralls

@jdevcs
Copy link
Contributor Author

jdevcs commented May 4, 2022

#4911 already has approval for changes in this PR so merging into 1.x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants