Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@avkos
Copy link
Contributor

@avkos avkos commented Apr 15, 2022

  • chore: fix eth abi typings

  • fix: export/declare AbiCoder

Co-authored-by: Chance Hudson [email protected]
Co-authored-by: Junaid [email protected]

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

* chore: fix eth abi typings

* fix: export/declare AbiCoder

Co-authored-by: Chance Hudson <[email protected]>
Co-authored-by: Junaid <[email protected]>
@render
Copy link

render bot commented Apr 15, 2022

@avkos avkos mentioned this pull request Apr 15, 2022
14 tasks
@avkos avkos requested review from nazarhussain and nikoulai April 15, 2022 11:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2172251810

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 265 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 74.495%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 7 85.42%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 44 9.66%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 2162197348: 2.3%
Covered Lines: 3242
Relevant Lines: 4107

💛 - Coveralls

@avkos avkos merged commit f2036c0 into 1.x Apr 15, 2022
@avkos avkos deleted the chore__fix_eth_abi_typings_ branch April 15, 2022 14:00
@avkos avkos removed the request for review from nikoulai April 15, 2022 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants