This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fixes calling toHexString on undefined gasPrice #4903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoulai
approved these changes
Mar 30, 2022
Pull Request Test Coverage Report for Build 2066446704
💛 - Coveralls |
jdevcs
reviewed
Mar 30, 2022
jdevcs
approved these changes
Mar 31, 2022
avkos
approved these changes
Mar 31, 2022
jdevcs
changed the base branch from
1.x
to
junaid/4903e2ewintestsforundefgaspricepr
jdevcs
added a commit
that referenced
this pull request
Apr 13, 2022
* Fixes calling toHexString on undefined gasPrice Fixes #4902 Co-authored-by: Drew Marsh <[email protected]>
Contributor
|
This PR is merged into 1.x via #4940 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where, when
handleRevertwas enabled and the call was toeth_sendRawTransaction, the logic would blindly callparsedTx.gasPrice.toHexString(). However, for EIP-1559 calls,gasPricewill always beundefinedand this code will now throw an internal exception which is caught and then rethrow an error that indicates that the reason couldn't be retrieved.Fixes #4902
Type of change
Checklist:
I have commented my code, particularly in hard-to-understand areas.N/AI have made corresponding changes to the documentation.N/AAny dependent changes have been merged and published in downstream modules.N/Anpm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.