Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Now we can remove the close event (#4825) #4839

Merged
jdevcs merged 6 commits into from
Mar 17, 2022
Merged

Now we can remove the close event (#4825) #4839

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1bf6859
Now we can remove the close event (#4825)
antonio-fr Mar 10, 2022
0fc81bb
change log update
jdevcs Mar 10, 2022
0d4a4b0
Merge branch '1.x' into junaid/depEventListener4786
jdevcs Mar 16, 2022
e27686d
Update CHANGELOG.md
Spacesai1or Mar 17, 2022
0356c4a
Merge branch '1.x' into junaid/depEventListener4786
Spacesai1or Mar 17, 2022
576a732
Merge branch '1.x' into junaid/depEventListener4786
jdevcs Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,12 @@ Released with 1.0.0-beta.37 code base.

## [1.7.2]

### Changed
- Remove deprecated `close` event listener (#4825) (#4839)

### Security
- `npm audit fix` to update libraries (#4860)

### Fixed
- Fix jsonrpc payload and response types (#4743) (#4761)
- Fix jsonrpc payload and response types (#4743) (#4761)

2 changes: 0 additions & 2 deletions packages/web3-core-requestmanager/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,6 @@ RequestManager.prototype.setProvider = function (provider, net) {
_this.provider.emit('end', event);
}
};
// TODO: Remove close once the standard allows it
this.provider.on('close', disconnect);
this.provider.on('disconnect', disconnect);

// TODO add end, timeout??
Expand Down