Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -523,4 +523,7 @@ Released with 1.0.0-beta.37 code base.

## [Unreleased]

## [1.8.0]
## [1.7.2]

### Fixed
Allowed more flexibility in typing the overly constrained `provider.disconnect` function (#4833)
3 changes: 2 additions & 1 deletion CONTRIBUTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,5 @@ Emergency releases are allowed to shorten waiting periods depending on the sever

There is precedent set for this in the 1.2.6 release (see [#3351](https://github.com/ethereum/web3.js/pull/3351)), where the consensus view was to make the smallest change necessary to address the emergency while waiving the `rc` process (meaning many existing additions to master were excluded).

This topic is under further org-wide discussion at [ethereum/js-organization#6](https://github.com/ethereum/js-organization/issues/6).
This topic was under further org-wide discussion [here](https://github.com/ethereum/js-organization/issues/6)
and [here](https://github.com/ChainSafe/web3.js/issues/3358).
2 changes: 1 addition & 1 deletion packages/web3-core-helpers/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class WebsocketProviderBase {

reset(): void;

disconnect(code: number, reason: string): void;
disconnect(code?: number, reason?: string): void;

connect(): void;

Expand Down