Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Jan 7, 2022

  • Debugging failing Windows test
  • Adds transactionPollingInterval to web3-eth
  • Adds transactionPollingInterval tests

* add: custom transaction polling interval

allow to set via options the interval which polls for TX status

* add: transactionPollingInterval to contract

* add: pass transactionPollingInterval to method

* Update CHANGELOG.md

* add: transactionPollingInterval docs

Co-authored-by: Nazar Hussain <[email protected]>
@render
Copy link

render bot commented Jan 7, 2022

@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Jan 7, 2022
CHANGELOG.md Outdated
### Added
- `maxPriorityFeePerGas` and `maxFeePerGas` added to `Transaction` and `TransactionConfig` interfaces (#4232) (#4585)

- `transactionPollingInterval` added to web3, contract and method constructor options. defaults to 1 second. (#4584)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.7.0 is already frozen under 1.7.0-rc so this change should be under future release instead of 1.7.0

@coveralls
Copy link

coveralls commented Jan 14, 2022

Pull Request Test Coverage Report for Build 1699133797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 467 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-2.2%) to 72.725%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-method/lib/index.js 10 93.85%
packages/web3-eth/lib/index.js 13 90.61%
packages/web3-eth-contract/lib/index.js 15 91.94%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 1688533323: -2.2%
Covered Lines: 3383
Relevant Lines: 4395

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants