-
Notifications
You must be signed in to change notification settings - Fork 5.1k
abi string type, fixes #216, #218, #219 #228
Conversation
|
Would be great to have tests for actual unicode / utf8. |
Conflicts: dist/web3-light.js dist/web3-light.min.js dist/web3.js dist/web3.min.js
|
Would be great to have tests for en- and decoding the following:
|
|
@debris please merge this PR asp, as solidity has now string and array support and the wallet dapp depends on that and its now not aligned with solidity. Additionally we should give a note to the community that auto conversion of bytes has been removed. |
|
@debris URF8 encoding seems to work fine, but decoding seems broken: > "\xc3\xa4\x00\x00\xc3\xa4"
"ä��ä"
> web3.fromAscii("\xc3\xa4\x00\x00\xc3\xa4")
"0xc3a40000c3a4"
> web3.toAscii('0xc3a40000c3a4')
"ä" |
|
@debris ok changed, could please also take a look and as well at the encoding issue i mentioned above above: > "\xc3\xa4\x00\x00\xc3\xa4"
"ää"
> web3.fromAscii("\xc3\xa4\x00\x00\xc3\xa4")
"0xc3a40000c3a4"
> web3.toAscii('0xc3a40000c3a4')
"ä" |
Conflicts: dist/web3-light.js dist/web3-light.min.js dist/web3.js dist/web3.min.js
…o strings Conflicts: dist/web3-light.js dist/web3-light.js.map dist/web3-light.min.js dist/web3.js dist/web3.js.map dist/web3.min.js
…rings containing internal zeros
decoding solidity strings does not use Let's merge! |
|
Ok but then lets actually rename |
This pr brings back
stringtype for solidity.@ethers @chriseth @frozeman can you review tests?