ServiceWorker: Do not set timing_allow_passed for filtered subresource responses - #61704
Merged
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
August 4, 2026 03:45
…e responses ServiceWorkerSubresourceLoader::StartResponse sets `timing_allow_passed` on the response head. This should only be set for same-origin (kBasic) or synthetic (kDefault) responses, and not for filtered responses (kCors, kOpaque, kOpaqueRedirect, etc.). TAG=agy CONV=486ca596-5fda-41bd-8a3e-dfe09b7d70fe Bug: 517092658 Change-Id: Iae1cb465902187cc8724d1000676451a5c68f18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8182169 Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/main@{#1673052}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8182169
branch
from
August 4, 2026 03:45
5d8e987 to
74a0682
Compare
wpt-pr-bot
approved these changes
Aug 4, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceWorkerSubresourceLoader::StartResponse sets
timing_allow_passedon the response head. This should only be set for same-origin (kBasic)
or synthetic (kDefault) responses, and not for filtered responses
(kCors, kOpaque, kOpaqueRedirect, etc.).
TAG=agy
CONV=486ca596-5fda-41bd-8a3e-dfe09b7d70fe
Bug: 517092658
Change-Id: Iae1cb465902187cc8724d1000676451a5c68f18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8182169
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1673052}