Add tests for SVG foreignObjects being cloned by reference with use#59127
Open
MaPePeR wants to merge 2 commits intoweb-platform-tests:masterfrom
Open
Add tests for SVG foreignObjects being cloned by reference with use#59127MaPePeR wants to merge 2 commits intoweb-platform-tests:masterfrom
MaPePeR wants to merge 2 commits intoweb-platform-tests:masterfrom
Conversation
559f360 to
3396447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension of #55576 by @Psychpsyo, which added a test to allow
foreignObjectinsideuseelements.This PR adds two more test for
foreignObjectandusebehavior:use-foreignObject-with-restyle.htmltests if changing the background color of adivinside aforeignObject, that is duplicated withuse, changes the background color for all clones.foreignObjectis not yet supported foruseat all.use-foreignObject-with-canvas.htmltests if a canvas inside aforeignObject, that is duplicated withuse, is rendered multiple times.I tried to write the tests in a way, that it fails with blue color, when
foreginObjectinsideuseis not supported at all and only fail with red, when the restyle isn't applied or the canvas content isn't rendered. I hope that is the intended usage of the different colors.The behavior of the restyle test in Firefox is also kind of an indication to me, that the canvas test should also pass, because it means, that the
foreignObjectclones are not independent copies, but are linked.I don't think the spec is actually clear on what is supposed to happen, but I'd argue the expected behavior is the only one that is useful.
(Sadly I was not able to run the tests locally, because a Windows update broke my WSL 🙄😞.)