Fix :active state persistence when flex order changes during mousedown#59117
Open
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
Fix :active state persistence when flex order changes during mousedown#59117servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
servo-wpt-sync wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Apr 11, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
Signed-off-by: SharanRP <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_43953
branch
from
c180e4c to
3a80e93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a flex item's order property changes due to :active CSS, the element moves to a new position. Servo was incorrectly clearing the :active state on every mousemove when the hit test found a different element under the cursor, causing the element to flicker instead of staying active until release.
The fix tracks which element was activated on mousedown and only clears the :active state on mouseup, matching the behavior of Firefox and Chrome.
Fixes: #43862
Reviewed in servo/servo#43953