Restore focus on dialog close when dialog is focused#59104
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
Restore focus on dialog close when dialog is focused#59104chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
Dialogs only restore focus to the previously focused element on close when an element inside the dialog is focused. When there is no focusable element inside of the dialog and the dialog element itself becomes focused, we should restore focus to the previously focused element when the dialog is closed. This change matches the spec, which uses an inclusive descendant check on the dialog element. Fixed: 497884156 Change-Id: I48e0e617a82a3ebe784884bd60f7d81e2776b71d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dialogs only restore focus to the previously focused element on close
when an element inside the dialog is focused. When there is no focusable
element inside of the dialog and the dialog element itself becomes
focused, we should restore focus to the previously focused element when
the dialog is closed.
This change matches the spec, which uses an inclusive descendant check
on the dialog element.
Fixed: 497884156
Change-Id: I48e0e617a82a3ebe784884bd60f7d81e2776b71d
Reviewed-on: https://chromium-review.googlesource.com/7735579
WPT-Export-Revision: f0f41654242f65e602d71f2f3ebb01d358f11ccf