[SRI Message Signatures] Require an enforceable Unencoded-Digest.#59089
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
[SRI Message Signatures] Require an enforceable Unencoded-Digest.#59089chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Unencoded-Digest.#59089chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
If the `Unencoded-Digest` header contains an unknown algorithm, we can't enforce its assertions on the content we download. This enables forward compatibility with new algorithms, but also opens a hole in signature checks, insofar as the signature over an unenforceable digest is equally unenforceable. Here, we follow the spec change in [1] to require enforcability. [1]: WICG/signature-based-sri@c6300af Bug: 498080391 Change-Id: I7422e261831cd1af0da9fb97c603350733cff262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
Unencoded-Digestheader contains an unknown algorithm, we can'tenforce its assertions on the content we download. This enables forward
compatibility with new algorithms, but also opens a hole in signature
checks, insofar as the signature over an unenforceable digest is equally
unenforceable. Here, we follow the spec change in 1 to require
enforcability.
Bug: 498080391
Change-Id: I7422e261831cd1af0da9fb97c603350733cff262
Reviewed-on: https://chromium-review.googlesource.com/7734936
WPT-Export-Revision: ab476a84fcd9bb2a67bb7b51ffedb60c61ca89ad