Fix timeout in SharedWorker-extendedLifetime.html#59085
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
Fix timeout in SharedWorker-extendedLifetime.html#59085chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-2e58acf27f
branch
30 times, most recently
from
e6590cc to
0a3d92f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-2e58acf27f
branch
29 times, most recently
from
983e7ff to
c424aa7
Compare
The test was using a 1ms delay between closing one popup and opening another, which likely caused intermittent failures and timeouts in headless environments like wpt.fyi. This change increases the delay to 1000ms, matching the 'Wait for a second' comment in the code. Bug: 400473072 Change-Id: Ic8bf7cd47bd4ae362d9b9a3bd0c5081afc875772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7742622 Commit-Queue: Minoru Chikamune <[email protected]> Auto-Submit: Yoshisato Yanagisawa <[email protected]> Reviewed-by: Minoru Chikamune <[email protected]> Cr-Commit-Position: refs/heads/main@{#1612597}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was using a 1ms delay between closing one popup and opening
another, which likely caused intermittent failures and timeouts in
headless environments like wpt.fyi. This change increases the delay to
1000ms, matching the 'Wait for a second' comment in the code.
Bug: 400473072
Change-Id: Ic8bf7cd47bd4ae362d9b9a3bd0c5081afc875772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7742622
Commit-Queue: Minoru Chikamune <[email protected]>
Auto-Submit: Yoshisato Yanagisawa <[email protected]>
Reviewed-by: Minoru Chikamune <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1612597}