Enable scalefactor200 effect-reference-feimage tests #57019
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected vs actual results in this look identical to the eye and appear to be slight anti-aliasing differences at color boundaries. Detailed analysis: There are three unique and identical clusters of images. Cluster A - the expected rendering which is identical across platforms. Cluster B - the actual renderings without will-change Cluster C - the actual renderings with will-change Cluster B <-> C: Differ by 21 pixels with a max per-channel delta of 1. Cluster A <-> B and A <-> C: Differ by 0.9% of pixels with a max per-channel delta of 11. This CL modifies the image comparison to allow fuzzy matching with these values. Bug: 40118302 Change-Id: Iad0449727ea8e4bcc5ff45b3d207fe7aef6ebfcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6757627 Reviewed-by: Philip Rogers <[email protected]> Commit-Queue: Sam Fortiner <[email protected]> Cr-Commit-Position: refs/heads/main@{#1565140}
wpt-pr-bot
approved these changes
Jan 6, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected vs actual results in this look identical to the eye and
appear to be slight anti-aliasing differences at color boundaries.
Detailed analysis:
There are three unique and identical clusters of images.
Cluster A - the expected rendering which is identical across platforms.
Cluster B - the actual renderings without will-change
Cluster C - the actual renderings with will-change
Cluster B <-> C: Differ by 21 pixels with a max per-channel delta of 1.
Cluster A <-> B and A <-> C: Differ by 0.9% of pixels with a max
per-channel delta of 11.
This CL modifies the image comparison to allow fuzzy matching with these
values.
Bug: 40118302
Change-Id: Iad0449727ea8e4bcc5ff45b3d207fe7aef6ebfcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6757627
Reviewed-by: Philip Rogers <[email protected]>
Commit-Queue: Sam Fortiner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1565140}