wpt: Have ServoRefTestExecutor inherit from RefTestExecutor
#55812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `ProcessTestExecutor` is only used by Servo and doesn't add much
on top of `ServoExecutor`, merge the former into the latter.
Also make `ServoExecutor` a mixin so that the derived classes can
inherit from upstream `wptrunner`'s classes and avoid the diamond
inheritance of `TestExecutor` base class.
Another issue is that new changes in the
`RefTestImplementation.get_screenshot_list` method upstream conflicts
with the assumptions in Servo's executor:
- The `dpi` argument is used as an `int` although it is a string
- The `viewport_size` argument is treated as a tuple of ints but it is
in fact a string of the format `WxH`. It also treats the viewport
dimensions as being specified in device pixel coordinates while
Servo treats it as logical coordinates and will scale it by `dpi`.
These issues need to discussed with upstream and patched in
`RefTestImplementation`.
Finally, add back `**kwargs` argument to `ServoCrashtestExecutor`'s
constructor to fix web-platform-tests#40322.
Fixes web-platform-tests#40288, web-platform-tests#40322
Signed-off-by: Mukilan Thiyagarajan <[email protected]>
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Nov 1, 2025
|
⛔ The downstream PR has merged (servo/servo#40327), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
servo-wpt-sync
added
the
stale-servo-export
|
@jdm can you give this one a nudge? Seems like an unrelated Safari infrastructure issue to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ProcessTestExecutoris only used by Servo and doesn't add muchon top of
ServoExecutor, merge the former into the latter.Also make
ServoExecutora mixin so that the derived classes caninherit from upstream
wptrunner's classes and avoid the diamondinheritance of
TestExecutorbase class.Another issue is that new changes in the
RefTestImplementation.get_screenshot_listmethod upstream conflictswith the assumptions in Servo's executor:
dpiargument is used as anintalthough it is a stringviewport_sizeargument is treated as a tuple of ints but it isin fact a string of the format
WxH. It also treats the viewportdimensions as being specified in device pixel coordinates while
Servo treats it as logical coordinates and will scale it by
dpi.These issues need to discussed with upstream and patched in
RefTestImplementation.Finally, add back
**kwargsargument toServoCrashtestExecutor'sconstructor to fix #40322.
Testing: Tested on fork with changes from upstream's base executor.
Fixes #40288
Fixes #40322
Reviewed in servo/servo#40327