Correct <input pattern> test #38278
Merged
Correct <input pattern> test #38278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
tkent-google and
zqzhang
mathiasbynens
force-pushed
the
fix-pattern-test
branch
2 times, most recently
from
dd3e9b6 to
07c6385
Compare
mathiasbynens
force-pushed
the
fix-pattern-test
branch
from
07c6385 to
77ccfff
Compare
foolip
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this test wasn’t testing anything useful — it would “pass” just the same for any invalid or unsupported attribute (e.g.
pattern-lolwat-idontexist) in any browser.This patch fixes that by testing
.patterninstead of.getAttribute('pattern'), and adds some more<input pattern>tests.