Test if AbortController and AbortSignal perform brand checks #28092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
force-pushed
the
abort-controller-brand-checks
branch
from
82ca4f6 to
004da61
Compare
Member
|
This is already tested in http://wpt.live/dom/idlharness.any.worker.html (and non-worker variants) |
Contributor
Author
|
Ah, I see now. In do_member_operation_asserts and do_interface_attribute_asserts, the IDL harness tries to call the method/getter on an empty object ( My apologies. I'll tell the Node people to actually run the IDL harness tests. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties and methods on these interfaces should perform a brand check on their receiver (as required by Web IDL). However, this is currently untested, since the IDL harness doesn't know how to call an interface method. This makes them easy to miss for implementors, such as in nodejs/node#37720.
This PR adds tests for these brand checks. These are upstreamed from nodejs/node#37720, which in turn are based on these WPT tests for Streams.