Skip to content

Conversation

@lukebjerring
Copy link
Contributor

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@lukebjerring
Copy link
Contributor Author

lukebjerring commented Jul 10, 2018

Blocked by #7583

@lukebjerring lukebjerring force-pushed the idl-file-updates-css-typed-om branch from 0866f50 to 5120638 Compare July 18, 2018 14:01
@wpt-pr-bot wpt-pr-bot requested a review from darrnshn July 18, 2018 14:01
@lukebjerring lukebjerring requested a review from foolip July 18, 2018 14:03
@lukebjerring
Copy link
Contributor Author

@foolip - note that the change to cssom.idl is actually a change to match the current spec state:
https://github.com/w3c/csswg-drafts/blob/master/cssom-1/Overview.bs

@lukebjerring lukebjerring force-pushed the idl-file-updates-css-typed-om branch from 5120638 to 9141931 Compare August 2, 2018 10:28
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and Firefox, seems to work well enough. Some failing tests due to #9790, but don't suggest blocking on that

@foolip foolip merged commit b66333a into web-platform-tests:master Aug 2, 2018
@lukebjerring lukebjerring deleted the idl-file-updates-css-typed-om branch October 5, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants