fix(fileCodeBlock): should support hmr #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Hot Module Replacement (HMR) support for file code blocks by enabling dependency tracking when external files are imported into markdown/MDX content. This ensures that changes to imported files trigger rebuilds during development.
- Added
addDependencyparameter to the file code block processing pipeline - Modified the remark plugin to track file dependencies for HMR
- Updated the MDX loader to pass the dependency tracking function through the processing chain
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/node/mdx/remarkPlugins/fileCodeBlock.ts | Added dependency tracking when reading external files for code blocks |
| packages/core/src/node/mdx/processor.ts | Updated compile function to accept and pass through addDependency parameter |
| packages/core/src/node/mdx/options.ts | Modified createMDXOptions to accept and forward addDependency to remark plugins |
| packages/core/src/node/mdx/loader.ts | Added addDependency from loader context to the compile options |
JounQin
approved these changes
Jul 28, 2025
Timeless0911
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(fileCodeBlock): should support hmr
Related Issue
Checklist